Re: [PATCH v10 07/41] KVM: guest_memfd: Stub in ability to enable in-place shared<=>private conversion
Ackerley Tng <[email protected]>
| Newsgroups | org.kernel.vger.linux-trace-kernel,dev.linux.lists.linux-coco,org.kernel.vger.kvm,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kvack.linux-mm |
|---|---|
| Message-ID | <CAEvNRgFd-6-QxR7w8SxPRa0UU+AAF7pDupLP8cPbQ9y3m=2QVw@mail.gmail.com> |
Xiaoyao Li <[email protected]> writes: > On 8/10/2026 11:01 PM, Sean Christopherson wrote: >>> As mentioned in v9, the name is confusing. >>> >>> kvm_gmem_mem_is_private >>> >>> ? >> Ya, +1 to kvm_gmem_mem_is_private. > > So kvm_gmem_mem_is_private() calls kvm_gmem_is_private_mem() > internallly. Ummmm. How about kvm_gmem_mem_is_private(kvm, gfn) __gmem_mem_is_private(inode, index) <== this is a static function anyway, though it calls kvm_gmem_get_attributes(inode, entry) or kvm_gmem_gfn_is_private(kvm, gfn) kvm_gmem_is_private_mem(inode, index) (rename the vm stuff with the suffix gfn_is_private()) or (current, it is actually weird) kvm_gmem_mem_is_private(kvm, gfn) kvm_gmem_is_private_mem(inode, index) or kvm_gmem_mem_is_private(kvm, gfn) kvm_gmem_index_is_private(inode, index)