Re: [PATCH 1/2] dmaengine: use dma_chan_name() helper to get per-channel device name
Frank Li <[email protected]>
| Newsgroups | org.kernel.vger.linux-trace-kernel,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.dmaengine,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-tegra |
|---|---|
| Message-ID | <an8_HLw4qZX-tjlj@SMW015318> |
On Fri, Aug 14, 2026 at 11:03:48AM +0300, Andy Shevchenko wrote: > On Wed, Aug 12, 2026 at 05:24:08PM -0400, [email protected] wrote: > > > Use the existing dma_chan_name() helper to obtain the per-channel device > > name instead of open-coding: dev_name(chan->dev->device) / > > dev_name(chan2dev()) > > > > Simplify the code and improve consistency. > > > > No functional change intended. > > ... > > > ret = devm_request_irq(dev, lchan->irq, loongson2_cmc_dma_chan_irq, IRQF_SHARED, > > - dev_name(chan2dev(lchan)), lchan); > > + dma_chan_name(&lchan->vchan.chan), lchan); > > Depending on the amount of users (and I expect there is a number), I would > expect specific API for virt-dma case. Make sense, I consider it before. Let's wait for while for patch2's comments Frank > > > if (ret) > > return ret; > > -- > With Best Regards, > Andy Shevchenko > >