Re: [PATCH v3 2/4] rv/reactors: propagate rv_register_reactor() error from reactor init

Nam Cao <[email protected]>
Newsgroups org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
[email protected] writes:

> From: Wen Yang <[email protected]>
>
> Both register_react_printk() and register_react_panic() ignore the
> return value of rv_register_reactor() and always return 0.  If the
> registration fails (e.g. a duplicate reactor name), the init functions
> silently report success even though the reactor was not registered.
>
> Propagate the error from rv_register_reactor() so a failed registration
> is reported instead of being silently ignored.
>
> Suggested-by: Gabriele Monaco <[email protected]>
> Reviewed-by: Gabriele Monaco <[email protected]>
> Signed-off-by: Wen Yang <[email protected]>

Reviewed-by: Nam Cao <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.