Re: [RFC PATCH] libtraceevent: Increase libtraceevent logging when verbose

Jiri Olsa <[email protected]> Thu, 10 Jun 2021 22:47:41 +0200
Newsgroups org.kernel.vger.linux-trace-users,org.kernel.vger.linux-kernel,org.kernel.vger.linux-perf-users
Message-ID <YMJ6bUQ8yXT+uMAF@krava>
On Thu, Jun 10, 2021 at 03:59:15PM -0400, Steven Rostedt wrote:
> On Thu, 10 Jun 2021 21:08:32 +0200
> Jiri Olsa <[email protected]> wrote:
> 
> > Michael did the libtraceevent detection and dynamic linking support:
> >   https://lore.kernel.org/linux-perf-users/[email protected]/
> > 
> > I think we should have that in Fedora/RHEL rpms already, or it's on the way.
> > 
> > The detection code could be change to contain things we need.
> 
> Or it can also be changed to export the version too?
> 
> LIBTRACEEVENT_VERSION = $(shell pkg-config --modversion libtraceevent | perl -e '$ver=<>; @v=split /,/,$ver; printf "%d\n", $v[0] * 255 * 255 | $v[1] * 255 | $v[2];')
> 
> -DLIBTRACEFS_VERSION=$(LIBTRACEEVENT_VERSION)

so the feature detection just gives out on/off answers,
but we can easily put above to perf's makefile

jirka

> 
> Then in C have:
> 
> #define VERSION(a,b,c) ((a)*255*255|(b)*255|(c))
> 
> #if LIBTRACEEVENT_VERSION >= VERSION(1,2,3)
> 
> To test if the libtraceevent feature is available?
> 
> -- Steve
>