Re: [PATCH v2 0/2] Fix initialization for Generic Clone X-Input Gamepads
Nikhil Solanke <[email protected]>
| Newsgroups | org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <CAFgddhLD5xJYf4SjJ3Q34PBEq_k=g-W3=UR0RCSL85OSw6KPHg@mail.gmail.com> |
On Sun, 26 Jul 2026 at 22:44, Ishaan Dandekar <[email protected]> wrote: > > This patch series fixes a hardware panic preventing certain generic X-Input > clone controllers (specifically 0283:0001) from functioning correctly > in Linux. > > When the controller is plugged in, the USB core requests its configuration > using a 9-byte request. The controller's firmware fails, disconnects, and > shape-shifts into a fallback Android mode, completely losing its X-Input > capabilities and haptic feedback (rumble). > > Patch 1 (by Nikhil Solanke) builds the underlying core logic to allow > a 255-byte config request (mimicking Windows behavior). > Patch 2 adds this specific controller's hardware ID to the new quirk list, > preventing the crash and locking it in X-Input mode. > > Note: While these USB patches keep the device stable in X-Input mode, a > companion patch is being submitted separately to the linux-input subsystem > (drivers/input/joystick/xpad.c) to ensure the device is routed correctly > and retains full haptic feedback and functionality. > > Changes in v2: > - Added missing Signed-off-by from transmitter to Patch 1. > - Wrapped commit message in Patch 2 to 72 columns. > - Removed trailing whitespace in Patch 2. > - Dropped the Input/xpad routing patch (sent separately to linux-input) > > Ishaan Dandekar (1): > usb: quirks: Add ShanWan gamepad to quirk list > > Nikhil Solanke (1): > usbcore: Add quirk for 255-bytes initial config read > > .../admin-guide/kernel-parameters.txt | 10 +++++ > drivers/usb/core/config.c | 39 +++++++++++++++---- > drivers/usb/core/quirks.c | 7 ++++ > include/linux/usb/quirks.h | 3 ++ > 4 files changed, 52 insertions(+), 7 deletions(-) > > -- > 2.34.1 You should not include my patches in your series. My patch series will be applied first separately. Just send your own patch with a note that your patch depends on my patchseries. These guidelines are present are in Documentation/process/submitting-patches.rst. Make sure to go through them once. Also, I will be updating my patchseries with some minor changes, so this patchset kinda becomes invalid as my patch in here is outdated. You'll also need to use the updated link when mentioning this dependency. Thanks, Nikhil Solanke