Re: [PATCH] thunderbolt: Initialize ->domain_released completion before it is being used
Mika Westerberg <[email protected]>
| Newsgroups | org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jul 28, 2026 at 08:52:22AM +0200, Mika Westerberg wrote: > Both Woody and Marek reported following crash: > > BUG: unable to handle page fault for address: fffffffffffffff8 > Call Trace: > <TASK> > device_release+0x43/0x90 > kobject_cleanup+0x3c/0x180 > icm_probe+0x19c/0x550 [thunderbolt] > nhi_probe+0x1a4/0x370 [thunderbolt] > local_pci_probe+0x41/0x90 > pci_call_probe+0x5b/0x1a0 > ... > > This only triggers on the error path when icm_probe() fails and the > domain structure is released, it tries to complete() uninitialized > completion. > > Fix this by initializing the completion earlier. > > Reported-by: Marek Marczykowski-Górecki <[email protected]> > Closes: https://lore.kernel.org/linux-usb/amdezCBiW4fd_DuB@mail-itl/ > Reported-by: Woody Suwalski <[email protected]> > Closes: https://lore.kernel.org/linux-usb/[email protected]/ > Fixes: f5cc545f5969 ("thunderbolt: Wait for tb_domain_release() to complete when driver is removed") > Signed-off-by: Mika Westerberg <[email protected]> Applied to thunderbolt.git/fixes.