Re: [PATCH net-next v3 06/13] ax88179_178a: EEE setup for AX88179A-based chips

On 24/07/2026 18:31, Andrew Lunn wrote:
>> +	if (ax179_data->phylink) {
>> +		ret = phylink_ethtool_get_eee(ax179_data->phylink, data);
>> +		/* AX88279 MAC does not support 2500Mbit EEE */
>> +		linkmode_set_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, mask);
>> +		linkmode_andnot(data->supported, data->supported, mask);
> 
> When you tell phylink the MACs EEE capabilities, this will go away.
Fixed in v4 with lpi_capabilities.

> 
>> -	return ax_write_mmd(dev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, tmp16);
>> +	if (priv->phylink)
>> +		return phylink_ethtool_set_eee(priv->phylink, data);
>> +
>> +	tmp16 = linkmode_to_mii_eee_cap2_t(data->advertised);
>> +	return ax_write_mmd(dev, MDIO_MMD_AN, MDIO_AN_EEE_ADV2, tmp16);
> 
> The phylib should do this. All the MAC driver needs is enable/disable
> the LPI timer. Nothing more.
> Fixed in v4 by using phylink exclusively.

Birger