Re: [PATCH net-next v4 10/12] ax88179_178a: update driver information

Birger Koblitz <[email protected]> Sun, 2 Aug 2026 18:21:42 +0200
Newsgroups org.kernel.vger.linux-usb,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <[email protected]>

On 31/07/2026 21:45, Andrew Lunn wrote:
>> -config USB_NET_AX88179_178A
>> -	tristate "ASIX AX88179/178A USB 3.0/2.0 to Gigabit Ethernet"
>> +config USB_NET_AX88179
>> +	tristate "ASIX AX88179/179A/178A USB 3.0/2.0 to Gigabit Ethernet"
>>   	depends on USB_USBNET
>> +	select PHYLINK
> 
> It is possible 0-day might complain about the earlier patches, the
> build failing because PHYLINK is not selected. You might need this
> change in an earlier patch?
Build works, but nevertheless I moved the select PHYLINK to commit where the
dependency is introduced.

> 
>> +	select AX88796B_PHY
>>   	select CRC32
>>   	select PHYLIB
> 
> I don't remember the logic, but it could be PHYLINK selects PHYLIB, so
> you can remove it here.
PHYLINK selects PHYLIB so only PHYLIB is needed. Fixed in v5.