Re: [PATCH 01/11] usb: cdns3: Remove redundant dev_err()

On 26-07-31 11:54:35, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"),
> devm_request_irq() and devm_request_threaded_irq() automatically log
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <[email protected]>

Acked-by: Peter Chen <[email protected]>

Peter
> ---
>  drivers/usb/cdns3/core.c | 4 +---
>  drivers/usb/cdns3/drd.c  | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> index 504bdf13ea80..87122fb5bdb8 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -449,10 +449,8 @@ int cdns_init(struct cdns *cdns)
>  						IRQF_SHARED,
>  						dev_name(cdns->dev), cdns);
>  
> -		if (ret) {
> -			dev_err(cdns->dev, "couldn't register wakeup irq handler\n");
> +		if (ret)
>  			goto role_switch_unregister;
> -		}
>  	}
>  
>  	ret = cdns_drd_init(cdns);
> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
> index d2bb682e4552..42f13757d904 100644
> --- a/drivers/usb/cdns3/drd.c
> +++ b/drivers/usb/cdns3/drd.c
> @@ -509,10 +509,8 @@ int cdns_drd_init(struct cdns *cdns)
>  					cdns_drd_thread_irq,
>  					IRQF_SHARED,
>  					dev_name(cdns->dev), cdns);
> -	if (ret) {
> -		dev_err(cdns->dev, "couldn't get otg_irq\n");
> +	if (ret)
>  		return ret;
> -	}
>  
>  	state = readl(&cdns->otg_regs->sts);
>  	if (OTGSTS_OTG_NRDY(state)) {
> -- 
> 2.34.1
> 

-- 

Thanks,
Peter Chen