Re: [PATCH v2] usb: gadget: f_phonet: fix use-after-free in pn_bind
Greg KH <[email protected]> Tue, 4 Aug 2026 10:21:40 +0200
| Newsgroups | org.kernel.vger.linux-usb,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <2026080445-dyslexia-shell-2db3@gregkh> |
On Tue, Aug 04, 2026 at 04:18:53PM +0800, Nguyen Quang Le Kien wrote: > On Tue, Aug 04, 2026 at 09:52:53AM +0200, Greg KH wrote: > > Did this new version properly run through syzbot and it reported it succeeded? > > > > This isn't needed as you added it to the .h file, right? > > > > And you didn't answer my question about LLM use. > > Not yet - I sent v2 about 30 minutes ago and syzbot hasn't picked it up. > I'll wait for the test result before sending v3. Please always do that before asking a human to review it. > You're right about the redundant include; that will be gone in v3. > > On the LLM question: I used it as a drafting assistant for the v1 > changelog and comment wording, but the race analysis and the actual fix > are my own, and I build-tested the patch. The over-formulaic changelog > and leaving the old stale "no race" comment in v1 were on me. I wrote v2 > and the upcoming v3 directly. Will send v3 once syzbot reports back. Please always document your LLM usage, as our rules require you to. thanks, greg k-h