[PATCH] usb: serial: digi_accelport: fix crash on SPARC
Oliver Neukum <[email protected]> Tue, 4 Aug 2026 12:51:50 +0200
| Newsgroups | org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <[email protected]> |
The helper function cond_wait_interruptible_timeout_irqrestore()
reenables interrupts. It does so by means of the flags saved
by spin_lock_irqsave() in the caller.
On SPARC these flags can be used only inside the same stack
frame. Details can be found in
https://www.kernel.org/pub/linux/kernel/people/rusty/kernel-locking/x467.html
If the compiler decides to not inline the helper function,
the kernel will crash on SPARC if the helper is executed. Hence the
compiler needs to be forced to always inline the function.
The bug was inadvertedly introduced by an adaption to modern
coding standards.
Fixes: c6d61269f530e ("digi_acceleport: Drag the driver kicking and screaming into coding style")
Signed-off-by: Oliver Neukum <[email protected]>
---
drivers/usb/serial/digi_acceleport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c
index a687217eadd7..50b89316ba1c 100644
--- a/drivers/usb/serial/digi_acceleport.c
+++ b/drivers/usb/serial/digi_acceleport.c
@@ -336,7 +336,7 @@ static struct usb_serial_driver * const serial_drivers[] = {
* with the equivalent code.
*/
-static long cond_wait_interruptible_timeout_irqrestore(
+static __always_inline long cond_wait_interruptible_timeout_irqrestore(
wait_queue_head_t *q, long timeout,
spinlock_t *lock, unsigned long flags)
__releases(lock)
--
2.55.0