[PATCH] usb: mtu3: simplify mtu3_probe_write() and ssusb_vbus_write()

Dmitry Antipov <[email protected]> Tue, 4 Aug 2026 16:49:36 +0300
Newsgroups org.kernel.vger.linux-usb
Message-ID <[email protected]>
Simplify 'mtu3_probe_write()' and 'ssusb_vbus_write()' by using the
convenient 'kstrtou32_from_user()' and 'kstrtobool_from_user()'.

Signed-off-by: Dmitry Antipov <[email protected]>
---
 drivers/usb/mtu3/mtu3_debugfs.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c
index c003049bafbf..a70daf77873c 100644
--- a/drivers/usb/mtu3/mtu3_debugfs.c
+++ b/drivers/usb/mtu3/mtu3_debugfs.c
@@ -300,14 +300,12 @@ static ssize_t mtu3_probe_write(struct file *file, const char __user *ubuf,
 	struct seq_file *sf = file->private_data;
 	struct mtu3 *mtu = sf->private;
 	const struct debugfs_reg32 *regs = debugfs_get_aux(file);
-	char buf[32];
+	int ret;
 	u32 val;
 
-	if (copy_from_user(&buf, ubuf, min_t(size_t, sizeof(buf) - 1, count)))
-		return -EFAULT;
-
-	if (kstrtou32(buf, 0, &val))
-		return -EINVAL;
+	ret = kstrtou32_from_user(ubuf, count, 0, &val);
+	if (ret)
+		return ret;
 
 	mtu3_writel(mtu->ippc_base, (u32)regs->offset, val);
 
@@ -470,16 +468,12 @@ static ssize_t ssusb_vbus_write(struct file *file, const char __user *ubuf,
 	struct seq_file *sf = file->private_data;
 	struct ssusb_mtk *ssusb = sf->private;
 	struct otg_switch_mtk *otg_sx = &ssusb->otg_switch;
-	char buf[16];
 	bool enable;
+	int ret;
 
-	if (copy_from_user(&buf, ubuf, min_t(size_t, sizeof(buf) - 1, count)))
-		return -EFAULT;
-
-	if (kstrtobool(buf, &enable)) {
-		dev_err(ssusb->dev, "wrong setting\n");
-		return -EINVAL;
-	}
+	ret = kstrtobool_from_user(ubuf, count, &enable);
+	if (ret)
+		return ret;
 
 	ssusb_set_vbus(otg_sx, enable);
 
-- 
2.55.0