Re: [PATCH] usb: serial: digi_accelport: fix crash on SPARC
Johan Hovold <[email protected]> Tue, 4 Aug 2026 16:46:37 +0200
| Newsgroups | org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Aug 04, 2026 at 12:51:50PM +0200, Oliver Neukum wrote: > The helper function cond_wait_interruptible_timeout_irqrestore() > reenables interrupts. It does so by means of the flags saved > by spin_lock_irqsave() in the caller. > On SPARC these flags can be used only inside the same stack > frame. Details can be found in > > https://www.kernel.org/pub/linux/kernel/people/rusty/kernel-locking/x467.html > > If the compiler decides to not inline the helper function, > the kernel will crash on SPARC if the helper is executed. I too had seen that comment about the messed up SPARC, but some years back I looked into it and concluded that this hasn't been the case for a very long time. Specifically, the comment you refer to was removed from the in-tree version of that document in 2004 after SPARC was fixed. Johan