Re: [PATCH] usb: dwc3: simplify dwc3_lsp_write()

Thinh Nguyen <[email protected]> Wed, 5 Aug 2026 01:17:30 +0000
Newsgroups org.kernel.vger.linux-usb
Message-ID <anKPIMtwcn-SabvF@vbox>
On Tue, Aug 04, 2026, Dmitry Antipov wrote:
> Simplify 'dwc3_lsp_write()' by using the convenient
> 'kstrtou32_from_user()'.
> 
> Signed-off-by: Dmitry Antipov <[email protected]>
> ---
>  drivers/usb/dwc3/debugfs.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index 65d909e4b785..01ebd73198e0 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -367,14 +367,10 @@ static ssize_t dwc3_lsp_write(struct file *file, const char __user *ubuf,
>  	struct seq_file		*s = file->private_data;
>  	struct dwc3		*dwc = s->private;
>  	unsigned long		flags;
> -	char			buf[32] = { 0 };
>  	u32			sel;
>  	int			ret;
>  
> -	if (copy_from_user(&buf, ubuf, min_t(size_t, sizeof(buf) - 1, count)))
> -		return -EFAULT;
> -
> -	ret = kstrtouint(buf, 0, &sel);
> +	ret = kstrtou32_from_user(ubuf, count, 0, &sel);
>  	if (ret)
>  		return ret;
>  
> -- 
> 2.55.0
> 

Acked-by: Thinh Nguyen <[email protected]>

BR,
Thinh