Re: [PATCH 0/6] usb: serial: ch341: small cleanups and fixes
Greg KH <[email protected]> Thu, 6 Aug 2026 07:29:37 +0200
| Newsgroups | org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <2026080617-cymbal-jaundice-44ee@gregkh> |
On Thu, Aug 06, 2026 at 10:02:25AM +0500, Vegom Doster wrote: > This series makes a few small cleanups and fixes to the CH341 serial > driver: > > - migrate the control-out path to usb_control_msg_send() so both > directions use the modern interface > - check the return value of ch341_configure() in reset_resume() > - encode the inverted bit-7 hardware difference as a quirk flag set > at configure time instead of a version comparison in the baud-rate > setup path > - replace the obsolete speed_t typedef with unsigned int > - only update the cached baud rate when the register write succeeds, > keeping the software state consistent with the hardware > - annotate the break_end accesses with READ/WRITE_ONCE > > All changes were tested on real hardware (1a86:7523): TX/RX echo at > 9600 and 115200 baud, DTR/RTS toggling, and the divisor calculation was > verified for a range of line speeds. > > Signed-off-by: Mark Ivanov <[email protected]> Please slow down. This needs to be sent as a patch series, not all in one email, as the documentation asks. Also, don't send patches more than once a day at the most. And finally, these are not in the correct style, and can not be applied. Please take a look at the kernel documentation for how to do this in the proper format. If you have any questions, please let us know. thanks, greg k-h