Re: [RFC PATCH] usb: xhci: use BIT_ULL for CRCR bits

> > Makes sense, including observed symptoms.
> > 
> > A system with IOMMU would fault on top of that, but the accesses
> > are reads, so hopefully no corruption in absence of IOMMU.
> > 
> > > Happy to test alternate fix proposals! Thanks.
> > 
> > I think the sort of code you quoted should work without surprises,
> > so widening these macros to ULL is right.
> > 
> > And there is a few more. They currently don't break anything, but
> > neither does CMD_RING_ABORT or CMD_RING_RUNNING for that matter.
> > 
> > ERST_EHB
> > EP_CTX_CYCLE_MASK
> > 
> > Let's see what Mathias thinks about it.
> > 
> 
> Fully agree,
> 
> We should probably try to get it into 7.2
> 
> Thanks Lachlan for debugging and elegantly describing the issue.

No problem - thanks for squeezing this in late in the cycle :).

lachlan