From: bui duc phuc <[email protected]>
devm_kasprintf() can fail when allocating the wakeup IRQ name. The error
was logged with dev_err_probe(), but its return value was ignored and
probe could continue with a successful return value.
Store the error returned by dev_err_probe() in ret and jump to the error
path to propagate the failure.
Reviewed-by: Frank Li <[email protected]>
Acked-by: Peter Chen <[email protected]>
Reported-by: Sashiko Bot <[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
Signed-off-by: bui duc phuc <[email protected]>
---
Link v2:
https://lore.kernel.org/all/[email protected]/
Changes in v3:
- Use the phy_shutdown label instead of err_clk as suggested by
Sashiko's review.
- Add Peter Chen's Acked-by tag.
- Add Frank Li's Reviewed-by tag.
drivers/usb/chipidea/ci_hdrc_imx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
index 9e529398c607..edbf9df9b8f2 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -532,8 +532,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
if (data->wakeup_irq > 0) {
irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s:wakeup", pdata.name);
if (!irq_name) {
- dev_err_probe(dev, -ENOMEM, "failed to create irq_name\n");
- goto err_clk;
+ ret = dev_err_probe(dev, -ENOMEM, "failed to create irq_name\n");
+ goto phy_shutdown;
}
ret = devm_request_threaded_irq(dev, data->wakeup_irq,
@@ -541,7 +541,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
IRQF_ONESHOT | IRQF_NO_AUTOEN,
irq_name, data);
if (ret)
- goto err_clk;
+ goto phy_shutdown;
}
ret = imx_usbmisc_init(data->usbmisc_data);
--
2.43.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.