Re: [PATCH] usb: hub: Set proper message when usb_hub_create_port_device() fails

Andy Shevchenko <[email protected]> Tue, 11 Aug 2026 10:14:33 +0300

Newsgroups	org.kernel.vger.linux-usb,org.kernel.vger.linux-kernel
Organization	Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID	<[email protected]>

On Tue, Aug 11, 2026 at 11:51:07AM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 11, 2026 at 12:31 AM Andy Shevchenko
> <[email protected]> wrote:
> > On Tue, Jul 28, 2026 at 06:00:04PM +0800, Chen-Yu Tsai wrote:

...

> > The 'message' is local to the function, why devm?
> > Shouldn't __free() be sufficient?
> 
> I hadn't thought of that.
> 
> The scope shouldn't be a problem, since it's declared and used at the top
> level. But we'd need a kfree_const() variant of __free(kfree). All the
> other error messages are just plain C string constants.

Sure, I just sent a patch.

-- 
With Best Regards,
Andy Shevchenko