[PATCH v2 00/14] Enable USB3 for Qualcomm IPQ5018 and IPQ5332
George Moussalem via B4 Relay <[email protected]>
| Newsgroups | org.kernel.vger.linux-usb,org.infradead.lists.linux-phy,org.kernel.feeds.b4-sent,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Patch series adds Qualcomm 22ull Super-Speed USB UNIPHY driver support present in Qualcomm IPQ5018 and IPQ5332 SoC which is required to enable USB3. This PHY is interfaced with SNPS DWC3 USB and SNPS DWC PCIe. Either one of the interface can use it via the mux selection present in the TCSR register. Current patch series adds the support for UNIPHY with DWC3 USB. --- Changes in v2: - Rebased on top of master tree - Included support for IPQ5018 - Changed bindings filename to match compatible string - Dropped items from compatible list in bindings file - Added required block in bindings file - Removed double space of reset property in example in bindings file - Added branching logic based on compatible string to define the right clocks per SoC in bindings file - Renamed phy driver to phy-qcom-uniphy-usb-ss-22ull.c - Added missing error handling uniphy_usb_init in phy driver - Changed to use devm_clk_hw_register_fixed_rate to register fixed rate pipe clock - Changed to use devm_of_clk_add_hw_provider to register clock provider - Release exclusive get of vdd and changed to devm_regulator_get as the regulator supply is also acquired by the m31 USB2 phy driver - Inlined acquisition of clocks to phy probe function - Use reverse xmas tree sorting of variables in phy driver probe - Moved USB mux selection away from phy init to probe as it needs to be set before the controller is taken out of reset. - Flattened the USB controller nodes in line with latest bindings and flattened driver approach for both SoCs. - Set clock frequencies in IPQ5018 controller node to ensure they're parented correctly and override any freqs set by the bootloader. - Removed patch to add usb phy node for IPQ5332 as the pcie0 phy shares the same MMIO as the usb3 phy. Hence, chose the approach to override the compatible string of said node and assign the right clocks, reset, and related properties upon enabling it as a USB3 phy instead of adding a new node with the same unit and reg address space. - Link to v1: https://lore.kernel.org/r/[email protected] --- George Moussalem (7): arm64: dts: qcom: ipq5018: Add USB Super-Speed PHY node arm64: dts: qcom: ipq5332: Flatten usb controller node arm64: dts: qcom: ipq5018: Flatten usb controller node dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5018 arm64: dts: qcom: ipq5018: Add clocks required for USB3 support arm64: dts: qcom: ipq5018: Add Super-Speed UNIPHY to USB node arm64: dts: qcom: ipq5018: Enable USB Super-Speed PHY Praveenkumar I (7): dt-bindings: phy: Document the Qualcomm IPQ5332 UNIPHY USB Super-speed PHY phy: qcom: Introduce Qualcomm IPQ5332 Super-Speed USB UNIPHY driver dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5332 arm64: dts: qcom: ipq5332: Add clocks required for USB3 support arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY to USB node arm64: dts: qcom: ipq5332: Enable USB Super-Speed PHY arm64: defconfig: Enable qcom USB UNIPHY driver .../phy/qcom,ipq5332-uniphy-usb-ss-phy.yaml | 111 ++++++++ .../devicetree/bindings/usb/qcom,snps-dwc3.yaml | 41 ++- arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 18 +- arch/arm64/boot/dts/qcom/ipq5018.dtsi | 82 +++--- arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 23 +- arch/arm64/boot/dts/qcom/ipq5332.dtsi | 57 ++-- arch/arm64/configs/defconfig | 1 + drivers/phy/qualcomm/Kconfig | 10 + drivers/phy/qualcomm/Makefile | 1 + .../phy/qualcomm/phy-qcom-uniphy-usb-ss-22ull.c | 304 +++++++++++++++++++++ 10 files changed, 577 insertions(+), 71 deletions(-) --- base-commit: 7b6a23be392e99e7a4cf72325697315460cf2a20 change-id: 20260803-ipq5018-usb3-4b289b1ed16e Best regards, -- George Moussalem <[email protected]>