Re: [PATCH] USB: gadget: stop propagating controller OF nodes

Johan Hovold <[email protected]>
Newsgroups org.kernel.vger.linux-usb,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Thu, Jul 02, 2026 at 04:53:50PM +0200, Johan Hovold wrote:
> Some UDC drivers propagate the controller OF node to the gadget device
> but there are no (and has never been any) users of this as the
> devicetree binding and composite driver support was never merged. [1]
> 
> Drop the unused and incomplete support for OF node propagation which if
> ever needed should be handled by UDC core.
> 
> Note that this also avoids probe failures when reusing an OF node that
> describe resources like pinctrl that are managed by driver core (cf.
> commit 48ed32482c41 ("usb: gadget: aspeed: Fix probe regression")).
> 
> Link: https://lore.kernel.org/all/[email protected]/ [1]
> Signed-off-by: Johan Hovold <[email protected]>
> ---
> 
> This was something I stumbled over when fixing a couple of gadget device
> name leaks. This one applies on top of those fixes:
> 
> 	https://lore.kernel.org/all/[email protected]/

These fixes are now in 7.2-rc5 (and usb-next) so can this one be picked
up for 7.3?

Let me know if you prefer a resend.

>  drivers/usb/gadget/udc/aspeed-vhub/dev.c | 2 --
>  drivers/usb/gadget/udc/aspeed_udc.c      | 1 -
>  drivers/usb/gadget/udc/at91_udc.c        | 1 -
>  drivers/usb/gadget/udc/bcm63xx_udc.c     | 1 -
>  drivers/usb/gadget/udc/fsl_udc_core.c    | 3 ---
>  drivers/usb/gadget/udc/lpc32xx_udc.c     | 1 -
>  6 files changed, 9 deletions(-)

Johan
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.