Re: [PATCH v3 1/2] dt-bindings: usb: Add Parade PS5169 redriver bindings

On Wed, Aug 12, 2026 at 05:30:46AM +0000, Esteban Urrutia wrote:
> On 8/11/26 5:11 AM, Krzysztof Kozlowski wrote:
> > On Mon, Aug 10, 2026 at 11:31:36PM -0400, Esteban Urrutia wrote:
> > 
> > A nit, subject: drop second/last, redundant "bindings". The
> > "dt-bindings" prefix is already stating that these are bindings.
> > See also:
> > https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23
> 
> Okay, will change that.
> 
> >> +
> >> +  parade,dp-eq-db:
> >> +    description:
> >> +      Equalization for DP channels.
> >> +      For example, <6 5> denotes an equalization of 6.5 dB.
> >> +    oneOf:
> >> +      - items:
> >> +          - enum: [ 2, 8, 10 ]
> >> +          - const: 0
> >> +      - items:
> >> +          - enum: [ 5, 6, 7, 8, 9 ]
> >> +          - const: 5
> > 
> > Eh, this is on me. I did not pay attention that values are fractional.
> > You should not be a list, but expressed as a single value, which is not
> > possible with int32. This might be the only ever practical use of mB :),
> > but I doubt that any engineer would find that readable, so let's go to
> > your previous code - direct register values - for all three properties.
> 
> -db$ specifies an int32-array type so it should allow for a list.
> So I'm not certain what you mean.

List means two separate values, not integer and decimal part.

Best regards,
Krzysztof