Re: [PATCH] dt-bindings: usb: xlnx,usb2: Make clocks required

Krzysztof Kozlowski <[email protected]>
Newsgroups org.kernel.vger.linux-usb,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <20260814-true-greedy-woodlouse-4cdb5c@quoll>
On Mon, Aug 10, 2026 at 09:15:48PM +0530, Radhey Shyam Pandey wrote:
> Add s_axi_aclk AXI4 clock support as a required property. Traditionally
> this IP was used on MicroBlaze platforms which had fixed clocks enabled
> all the time. But since it is a PL IP, it can also be used on SoC
> platforms like Zynq UltraScale+ MPSoC which combines processing system
> (PS) and user programmable logic (PL) into the same device. On these
> platforms instead of fixed enabled clocks it is mandatory to explicitly
> enable IP clocks for proper functionality.

I do not see the clocks being added. You made them only required, but
first sentence suggests you add them.

I still do not get why the traditional "MicroBlaze platforms which had
fixed clocks enabled all the time" are now broken and require the clocks.
IOW, what changed for devices which you claim do not need the clocks,
that they now need the clocks?

Maybe this should be required only on platforms which actually need it?

Best regards,
Krzysztof
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.