[PATCH] usb: f_fs-aio-simple: add NULL checks for malloc calls
longlong yan <[email protected]>
| Newsgroups | org.kernel.vger.linux-usb,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Add NULL checks for the return values of malloc() in the aio_simple FFS example application. If any of the four malloc calls (buf_in, buf_out, iocb_in, iocb_out) fails, the subsequent code would dereference NULL pointers in the main loop. Since free(NULL) is safe, the error path frees all four buffers unconditionally, then cleans up the remaining resources (io context, endpoint file descriptors) consistent with the existing cleanup at the end of the function. Signed-off-by: longlong yan <[email protected]> --- .../ffs-aio-example/simple/device_app/aio_simple.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c b/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c index 96616eb4600b..07ca1f136ad7 100644 --- a/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c +++ b/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c @@ -294,6 +294,19 @@ int main(int argc, char *argv[]) iocb_in = malloc(sizeof(*iocb_in)); iocb_out = malloc(sizeof(*iocb_out)); + if (!buf_in || !buf_out || !iocb_in || !iocb_out) { + perror("malloc"); + free(buf_in); + free(buf_out); + free(iocb_in); + free(iocb_out); + io_destroy(ctx); + for (i = 0; i < 2; ++i) + close(ep[i]); + close(ep0); + return 1; + } + while (1) { FD_ZERO(&rfds); FD_SET(ep0, &rfds); -- 2.43.0