Re: [PATCH net-next v7 05/14] ax88179_178a: Add HW support for AX179A-based chips
Jakub Kicinski <[email protected]>
| Newsgroups | org.kernel.vger.linux-usb,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 10 Aug 2026 14:33:30 +0200 Birger Koblitz wrote:
> This adds bindings and HW support for AX179A-based USB-Ethernet
> controllers. The AX179A-family of chips consists of the
> AX88279 (2.5GBit PHY)
> AX88179A/B (1GBit PHY, B variant has wider temperature range)
> AX772D/E (100Mbit PHY)
>
> The controllers all have the same vendor and device ID
> (0x0b95, 0x1790) and are distinguished by their BCD device versions,
> which are
> 2.00 AX88179A/B
> 3.00 AX88772D/E
> 4.00 AX88279
>
> For all chips, the driver calls the same ax88179a_bind() function
> and the chips are then distinguished by the chip version and
> BCD device ID. The AX179A-based chips all provide both a CDC-NCM
> compatible USB interface, and a proprietary vendor interface. By default,
> the proprietary vendor interface is not active and Linux will load the
> CDC-NCM driver to support the devices. If the ax88179_178a module is
> configured by the OS to have precedence over CDC-NCM, then this driver
> will switch the device to use the vendor interface, and the device will
> be controlled by the ax88179_178a driver when the device is probed again
> after an automatic reset by the device.
Two transiently unused functions here:
../drivers/net/usb/ax88179a_devices.c:397:13: warning: unused function 'ax88179a_mac_disable_tx_lpi' [-Wunused-function]
397 | static void ax88179a_mac_disable_tx_lpi(struct phylink_config *config)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/usb/ax88179a_devices.c:404:12: warning: unused function 'ax88179a_mac_enable_tx_lpi' [-Wunused-function]
404 | static int ax88179a_mac_enable_tx_lpi(struct phylink_config *config, u32 timer, bool tx_clk_stop)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
This blocked more expensive stages of our CI from running on the series,
it needs to be fixed.
--
pw-bot: cr