Re: [PATCH] usb: xhci-pci: Add AMD 600 series to xhci-pci-prom21

On 18-08-2026 11:05, Stephen Horvath wrote:
> It seems the xhci-pci-prom21 module only has IDs for the 800 series
> chipsets. However, this also seems to work for my X670 board, so I have
> added its DID (`0x43f7`) to the list.
> 
> `1022:43f7` also seems to be the only DID for the 600 series, on the PCI
> ID database (https://pci-ids.ucw.cz/read/PC/1022/43f7).
> 
> Cc: Jihong Min <[email protected]>
> Signed-off-by: Stephen Horvath <[email protected]>

Looks good to me. But you may add 0x43FA/0x43F9 they belong X620/X665 models respectively.

Acked-by: Shyam Sundar S K <[email protected]>

Thanks,
Shyam

> ---
>  drivers/usb/host/xhci-pci-prom21.c | 1 +
>  drivers/usb/host/xhci-pci.c        | 1 +
>  drivers/usb/host/xhci-pci.h        | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-pci-prom21.c b/drivers/usb/host/xhci-pci-prom21.c
> index 6486f4a09345..b41faa87f4eb 100644
> --- a/drivers/usb/host/xhci-pci-prom21.c
> +++ b/drivers/usb/host/xhci-pci-prom21.c
> @@ -111,6 +111,7 @@ static void prom21_xhci_remove(struct pci_dev *dev)
>  }
>  
>  static const struct pci_device_id pci_ids[] = {
> +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD) },
>  	{ /* end: all zeroes */ }
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index a8889081ae82..de132025d8a6 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -701,6 +701,7 @@ static const struct pci_device_id pci_ids_renesas[] = {
>  
>  /* handled by xhci-pci-prom21 if enabled */
>  static const struct pci_device_id pci_ids_prom21[] = {
> +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD) },
>  	{ /* end: all zeroes */ }
> diff --git a/drivers/usb/host/xhci-pci.h b/drivers/usb/host/xhci-pci.h
> index 11f435f94322..26a9edfcaceb 100644
> --- a/drivers/usb/host/xhci-pci.h
> +++ b/drivers/usb/host/xhci-pci.h
> @@ -4,6 +4,7 @@
>  #ifndef XHCI_PCI_H
>  #define XHCI_PCI_H
>  
> +#define PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7	0x43f7
>  #define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC	0x43fc
>  #define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD	0x43fd
>  
> 
> ---
> base-commit: bdab5605259ba5d6ff927c1a85cc83eb3ecfdacc
> change-id: 20260818-xhci-pci-prom21-ceb025d484a8
> 
> Best regards,
> --  
> Stephen Horvath <[email protected]>
>