Re: [PATCH 2/5] ARM: dts: mediatek: mt8127: Add watchdog support

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device tree nodes are not sorted by unit address.
--

commit 7452ca22e20f1d82f0774e2f81b86b3196a78313
Author: Zakariya Hadrami <[email protected]>
ARM: dts: mediatek: mt8127: Add watchdog support

This commit adds the watchdog node to the mt8127 device tree. It is
disabled by default since it was not present initially.

> diff --git a/arch/arm/boot/dts/mediatek/mt8127.dtsi b/arch/arm/boot/dts/mediatek/mt8127.dtsi
> index bd61ec7e70c0c..1855dda42710f 100644
> --- a/arch/arm/boot/dts/mediatek/mt8127.dtsi
> +++ b/arch/arm/boot/dts/mediatek/mt8127.dtsi
> @@ -159,5 +159,12 @@ uart3: serial@11005000 {
>  			clocks = <&uart_clk>;
>  			status = "disabled";
>  		};
> +
> +		watchdog: watchdog@10007000 {

[Severity: Low]
Should this node be sorted by its unit address? 

It looks like watchdog@10007000 is being placed after serial@11005000 at the
end of the soc node. Device tree styling conventions usually require sibling
nodes to be sorted in ascending order of their unit address, which would
place this earlier in the file (likely before timer@10008000).

> +			compatible = "mediatek,mt8127-wdt","mediatek,mt6589-wdt";
> +			reg = <0 0x10007000 0 0x100>;
> +			interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_LOW>;
> +			status = "disabled";
> +		};
>  	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2