Re: [PATCH] Watchdog: fix pretimeout noop governor logging and description

kernel test robot <[email protected]>
Newsgroups org.kernel.vger.linux-watchdog,dev.linux.lists.oe-kbuild-all,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Hi Lorenzo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on groeck-staging/hwmon]
[also build test WARNING on groeck-staging/hwmon-next groeck-staging/watchdog groeck-staging/watchdog-next linus/master v7.1 next-20260616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Egidio/Watchdog-fix-pretimeout-noop-governor-logging-and-description/20260617-032417
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon
patch link:    https://lore.kernel.org/r/20260616171955.658-1-lorenzoegidioms%40gmail.com
patch subject: [PATCH] Watchdog: fix pretimeout noop governor logging and description
config: i386-randconfig-141-20260617 (https://download.01.org/0day-ci/archive/20260617/[email protected]/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
smatch: v0.5.0-9185-gbcc58b9c
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260617/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> drivers/watchdog/pretimeout_noop.c:20:21: warning: more '%' conversions than data arguments [-Wformat-insufficient-args]
      20 |         pr_alert("watchdog%d: pretimeout event\n");
         |                           ~^
   include/linux/printk.h:534:27: note: expanded from macro 'pr_alert'
     534 |         printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
         |                                  ^~~
   include/linux/printk.h:401:21: note: expanded from macro 'pr_fmt'
     401 | #define pr_fmt(fmt) fmt
         |                     ^~~
   include/linux/printk.h:511:53: note: expanded from macro 'printk'
     511 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                                                     ^~~
   include/linux/printk.h:483:11: note: expanded from macro 'printk_index_wrap'
     483 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
         |                         ^~~~
   1 warning generated.


vim +20 drivers/watchdog/pretimeout_noop.c

    11	
    12	/**
    13	 * pretimeout_noop - No operation on watchdog pretimeout event
    14	 * @wdd: watchdog_device
    15	 *
    16	 * This function prints a message about pretimeout to kernel log.
    17	 */
    18	static void pretimeout_noop(struct watchdog_device *wdd)
    19	{
  > 20		pr_alert("watchdog%d: pretimeout event\n");
    21	}
    22	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.