Re: [PATCH] watchdog: lenovo_se30g2_se60_wdt: Watchdog for Lenovo SE30G2 and SE60

Guenter Roeck <[email protected]> Tue, 23 Jun 2026 19:21:27 -0700

Newsgroups	org.kernel.vger.linux-watchdog,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On 6/22/26 07:45, Mark Pearson wrote:
> Watchdog driver implementation for Lenovo SE30G2 and SE60 platforms.
> 
> Signed-off-by: Mark Pearson <[email protected]>
> ---
...
> +static int wdt_set_timeout(struct watchdog_device *wdog, unsigned int timeout)
> +{
> +	if (timeout < MIN_TIMEOUT || timeout > MAX_TIMEOUT)
> +		return -EINVAL;
> +
Unnecessary range check. Unnecessary call, actually.
See watchdog_dev.c:watchdog_set_timeout().

Guenter