Re: [PATCH] watchdog: lenovo_se30g2_se60_wdt: Watchdog for Lenovo SE30G2 and SE60
"Mark Pearson" <[email protected]>
| Newsgroups | org.kernel.vger.linux-watchdog,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jun 23, 2026, at 10:21 PM, Guenter Roeck wrote: > On 6/22/26 07:45, Mark Pearson wrote: >> Watchdog driver implementation for Lenovo SE30G2 and SE60 platforms. >> >> Signed-off-by: Mark Pearson <[email protected]> >> --- > ... >> +static int wdt_set_timeout(struct watchdog_device *wdog, unsigned int timeout) >> +{ >> + if (timeout < MIN_TIMEOUT || timeout > MAX_TIMEOUT) >> + return -EINVAL; >> + > Unnecessary range check. Unnecessary call, actually. > See watchdog_dev.c:watchdog_set_timeout(). > Agreed - will remove. Thanks for the review Mark