Re: [PATCH RFC v2 7/9] watchdog: rzv2h: Add syscon support for RZ/T2H and RZ/N2H WDT control register
"Lad, Prabhakar" <[email protected]>
| Newsgroups | org.kernel.vger.linux-watchdog,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc |
|---|---|
| Message-ID | <CA+V-a8tcFzoGBZ0NBE=612Py+E6gJ4MRqyT2QjxSN1s6Dv5CvQ@mail.gmail.com> |
Hi Guenter, Thank you for the review. On Thu, Jul 2, 2026 at 2:27 PM Guenter Roeck <[email protected]> wrote: > > On 7/2/26 05:31, Prabhakar wrote: > > From: Lad Prabhakar <[email protected]> > > > > On RZ/T2H and RZ/N2H SoCs the WDTDCR register resides in the second > > region of the System Controller (SYS) block at 0x81290000, which is > > shared with other peripherals. A dedicated SYS driver now manages this > > region and exposes it via a syscon regmap interface, making direct > > mapping of the WDTDCR register by the WDT driver no longer viable. > > > > Update the WDT driver to support both access methods to maintain > > backward compatibility with old device trees that use direct mapping: > > > > WHy don't you convert the driver to use regmap first and then just > update the regmap pointer for syscon support ? If that is not possible > for some reason, I would expect to see a detailed explanation. > Good point. I will send patch 6/9 and the regmap conversion patch separately, and I will send the syscon patch when the syscon changes are accepted. Cheers, Prabhakar