Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string 'apple,t8132-aic3' was not added to the conditional block enforcing '#interrupt-cells'.
--
commit 4be0e67c14a594eec020638f7ba5290c4bf05496
Author: Yureka Lilian <[email protected]>
dt-bindings: interrupt-controller: apple,aic2: Add apple,t8132 compatible
The Apple t8132 (M4) SoC uses an AIC3 as interrupt controller, same as
the M3 predecessor.
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> index d0d9a90e96e7b..7171c8c09feaf 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> @@ -44,6 +44,7 @@ properties:
> - items:
> - enum:
> - apple,t6030-aic3
> + - apple,t8132-aic3
[Severity: Low]
This isn't a bug, but should the 'apple,t8132-aic3' compatible string be added
to the conditional block enforcing the '#interrupt-cells' constraint?
Looking at the allOf if-then block further down in the file:
allOf:
- $ref: /schemas/interrupt-controller.yaml#
- if:
properties:
compatible:
contains:
enum:
- apple,t8112-aic
- apple,t8122-aic3
This conditional block enumerates the prior generations (t8112-aic, t8122-aic3)
but is missing the newly added t8132-aic3 compatible string.
While dt-validate may still enforce the constraint via the mandatory
'apple,t8122-aic3' fallback string matching in the contains clause, omitting
the new generation string from the enumeration directly violates the subsystem
rules for generating consistent schema checks.
> - const: apple,t8122-aic3
> - const: apple,t8122-aic3
>
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260705-apple-m4-initial-devicetrees-v1-0-e5655ee56523@cyberchaos.dev?part=5
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.