Re: [PATCH v2 05/10] dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles
[email protected] Wed, 15 Jul 2026 09:17:59 +0000
| Newsgroups | org.kernel.vger.linux-watchdog,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The commit message incorrectly duplicates 'apple,t6030-pmgr-pwrstate' when explaining the new compatible strings. -- --- Patch [5]: [PATCH v2 05/10] dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles --- commit 0f321dd30362858c61b0d6995914cf56752d651f Author: Janne Grunau <[email protected]> dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles This commit adds "apple,t6030-pmgr-pwrstate" and "apple,t6031-pmgr-pwrstate" compatible strings for Apple M3 Pro, Max, and Ultra SoCs. > The pmgr-powerstate registers on Apple M3 Pro, Max and Ultra SoCs are > compatible with "apple,t8103-pmgr-pwrstate". Add > "apple,t6030-pmgr-pwrstate" for M3 Pro and "apple,t6030-pmgr-pwrstate" > for M3 Max and Ultra as per-SoC compatibles. [Severity: Low] This isn't a bug, but there appears to be a typo in the commit message. It duplicates "apple,t6030-pmgr-pwrstate" instead of mentioning "apple,t6031-pmgr-pwrstate" for the M3 Max and Ultra. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20260715-apple-t603x-initial-devices-v2-0-df65b2485710@jannau.net?part=5