Re: [PATCH v2 10/10] arm64: dts: apple: Initial T6030 (M3 Pro) device trees

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `pinctrl_nub` device is missing its `power-domains` property, which is explicitly defined as `ps_nub_gpio` in `t6030-pmgr.dtsi`.
--

--- Patch [10]: [PATCH v2 10/10] arm64: dts: apple: Initial T6030 (M3 Pro) device trees ---
commit 2e87765dac6c4901eb4d023fc0b86ec40441a4ad
Author: Janne Grunau <[email protected]>

arm64: dts: apple: Initial T6030 (M3 Pro) device trees

This commit introduces minimal device trees for the M3 Pro SoC, supporting the
14-inch and 16-inch MacBook Pro models from November 2023. It includes base
device nodes in t6030.dtsi and device-specific overlays.

> diff --git a/arch/arm64/boot/dts/apple/t6030.dtsi b/arch/arm64/boot/dts/apple/t6030.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/apple/t6030.dtsi
[ ... ]
> +		pinctrl_nub: pinctrl@3641f0000 {
> +			compatible = "apple,t6030-pinctrl", "apple,t8103-pinctrl";
> +			reg = <0x3 0x641f0000 0x0 0x4000>;
> +
> +			interrupt-parent = <&aic>;

[Severity: Medium]
Is pinctrl_nub missing its power-domains property?

The ps_nub_gpio power domain is defined in t6030-pmgr.dtsi, but it doesn't
appear to be referenced here. Does this node need power-domains =
<&ps_nub_gpio>; added so the genpd dependency graph is complete?

> +			interrupts = <AIC_IRQ 472 IRQ_TYPE_LEVEL_HIGH>,
> +				     <AIC_IRQ 473 IRQ_TYPE_LEVEL_HIGH>,
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-apple-t603x-initial-devices-v2-0-df65b2485710@jannau.net?part=10