Re: [PATCH 7/7] arm: dts: mediatek: mt6589: add reset support for wdt

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The dt-binding schema fails to enforce `#reset-cells` as a required property for watchdog variants that act as reset providers, such as `mediatek,mt6589-wdt`.
--

--- Patch [7]: [PATCH 7/7] arm: dts: mediatek: mt6589: add reset support for wdt ---
commit 3940ed1252e6cfe8fc145910821de71c2c72776d
Author: Akari Tsuyukusa <[email protected]>

arm: dts: mediatek: mt6589: add reset support for wdt

This commit updates the MT6589 watchdog device tree node to support TOPRGU
resets by adding the #reset-cells property.

> diff --git a/arch/arm/boot/dts/mediatek/mt6589.dtsi b/arch/arm/boot/dts/mediatek/mt6589.dtsi
> index c6babc8ad2ba6..4d29ed495d31e 100644
> --- a/arch/arm/boot/dts/mediatek/mt6589.dtsi
> +++ b/arch/arm/boot/dts/mediatek/mt6589.dtsi
> @@ -136,6 +136,7 @@ uart3: serial@11009000 {
>  		wdt: watchdog@10000000 {
>  			compatible = "mediatek,mt6589-wdt";
>  			reg = <0x10000000 0x44>;
> +			#reset-cells = <1>;

[Severity: Medium]
Does the device tree binding schema for mediatek,mtk-wdt need an update
alongside this change?

Adding #reset-cells here indicates this watchdog variant now acts as a reset
provider. According to the dt-bindings subsystem guidelines, when hardware
gains new provider capabilities, the corresponding standard properties (like
#reset-cells) must be added to the required list in the schema with
appropriate constraints.

Without an allOf with if-then conditional block in
Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml to enforce
#reset-cells as required for mediatek,mt6589-wdt, functionally incomplete
device tree nodes missing this property will silently pass dt_binding_check
validation.

>  		};
>  	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=7