Re: [PATCH 5/7] dt-bindings: reset: Add bindings for MediaTek MT6589 reset controller

Krzysztof Kozlowski <[email protected]> Fri, 17 Jul 2026 11:18:12 +0200

Newsgroups	org.kernel.vger.linux-watchdog,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<20260717-rattlesnake-of-enjoyable-dignity-42da64@quoll>

On Fri, Jul 17, 2026 at 01:19:21AM +0900, Akari Tsuyukusa wrote:
> Add MT6589 reset controller bindings.
> 
> Signed-off-by: Akari Tsuyukusa <[email protected]>
> ---
>  include/dt-bindings/reset/mt6589-resets.h | 25 +++++++++++++++++++++++

Filename must match compatible.

Why is this separate from the patch adding the binding? Where is this
explained?

>  1 file changed, 25 insertions(+)
>  create mode 100644 include/dt-bindings/reset/mt6589-resets.h
> 
> diff --git a/include/dt-bindings/reset/mt6589-resets.h b/include/dt-bindings/reset/mt6589-resets.h
> new file mode 100644
> index 000000000000..18ef729022a9
> --- /dev/null
> +++ b/include/dt-bindings/reset/mt6589-resets.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2026 Akari Tsuyukusa <[email protected]>
> + */
> +
> +#ifndef _DT_BINDINGS_RESET_MT6589_RESETS_H
> +#define _DT_BINDINGS_RESET_MT6589_RESETS_H
> +
> +/* TOPRGU */
> +#define MT6589_TOPRGU_INFRA_RST		0
> +#define MT6589_TOPRGU_DISP_RST		1
> +#define MT6589_TOPRGU_MFG_RST		2
> +#define MT6589_TOPRGU_VENC_RST		3
> +#define MT6589_TOPRGU_VDEC_RST		4
> +#define MT6589_TOPRGU_IMG_RST		5
> +#define MT6589_TOPRGU_DDRPHY_RST	6
> +#define MT6589_TOPRGU_MD_RST		7
> +#define MT6589_TOPRGU_INFRA_AO_RST	8
> +#define MT6589_TOPRGU_MD_LITE_RST	9
> +#define MT6589_TOPRGU_APMIXED_RST	10
> +#define MT6589_TOPRGU_PWRAP_SPICTL_RST	11
> +
> +#define MT6589_TOPRGU_RST_NUM		12

Not a binding, drop.

Best regards,
Krzysztof