Re: [PATCH v2 3/7] dt-bindings: watchdog: Add compatible for MediaTek mt8167

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `mediatek,mt8167-wdt` compatible string is added as a standalone compatible (without fallback) in the DT bindings, but the patch series is missing the corresponding driver support and reset definitions header.
--

--- Patch [3]: [PATCH v2 3/7] dt-bindings: watchdog: Add compatible for MediaTek mt8167 ---
commit 666f2d36168cb1a5fa647ba2d10b40b0cd2f2240
Author: Luca Leonardo Scorcia <[email protected]>

dt-bindings: watchdog: Add compatible for MediaTek mt8167

This commit adds a dedicated compatible string for the MediaTek mt8167
watchdog. It replaces the previous fallback to mt6589-wdt since the
mt8167 hardware has 15 software resets instead of 12, and in a different
order.

> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> index 953629cb9558b..f514be8a5851d 100644
> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> @@ -26,6 +26,7 @@ properties:
>            - mediatek,mt6795-wdt
>            - mediatek,mt7986-wdt
>            - mediatek,mt7988-wdt
> +          - mediatek,mt8167-wdt

[Severity: Medium]
Will this new compatible string probe successfully without driver support?

Looking at the driver match table:

drivers/watchdog/mtk_wdt.c:mtk_wdt_dt_ids[] {
    { .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data },
    ...
}

It seems there is no match entry for "mediatek,mt8167-wdt".

Since this is added as a standalone compatible without a fallback to
an existing string, any device tree using it will fail to probe the
watchdog driver.

Additionally, the commit message mentions the mt8167 has 15 software resets
instead of 12, but there doesn't appear to be a corresponding dt-bindings
header exporting these new reset indices for device tree consumers to use.

>            - mediatek,mt8183-wdt
>            - mediatek,mt8186-wdt
>            - mediatek,mt8188-wdt

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3