Re: [PATCH 2/2] watchdog: pscrr: add watchdog pretimeout reason tracking
Faruque Ansari <[email protected]> Tue, 21 Jul 2026 16:35:04 +0530
| Newsgroups | org.kernel.vger.linux-watchdog,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <[email protected]> |
Hi Guenter, On 20-Jul-26 10:09 PM, Guenter Roeck wrote: > On Tue, Jul 14, 2026 at 03:22:35PM +0530, Faruque Ansari wrote: >> A watchdog pretimeout fires before the actual reset, giving the kernel >> a brief window to record what happened. Without this change that >> window goes unused and the next boot sees PSCR_UNKNOWN, making it >> impossible to tell a watchdog-driven reset from any other cause. >> >> Call set_psc_reason(PSCR_WATCHDOG_PRETIMEOUT) at the top of >> watchdog_notify_pretimeout() so the reason is recorded as soon as the >> pretimeout is signalled, before any governor action runs. >> >> Signed-off-by: Faruque Ansari <[email protected]> >> --- >> drivers/power/reset/pscrr.c | 3 ++- >> drivers/watchdog/watchdog_pretimeout.c | 3 +++ >> include/linux/power/power_on_reason.h | 1 + >> include/linux/reboot.h | 1 + >> kernel/reboot.c | 1 + > > This is a cross-subsystem change. As far as I can see it would > be easy to split it into two patches. Please do that. > > Guenter > Thanks for taking the time to review this. I'll split into separate PSCRR and watchdog patches in v2. Thanks, Faruque Ansari