[PATCH v2 8/8] watchdog: w83627hf_wdt: Report all initialization failures in probe
Paul Louvel <[email protected]> Sun, 26 Jul 2026 20:44:35 +0200
| Newsgroups | org.kernel.vger.linux-watchdog,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
The driver currently logs an error only if the chip initialization fails. Extend the error reporting to all failure paths in probe to improve diagnostics. Signed-off-by: Paul Louvel <[email protected]> --- drivers/watchdog/w83627hf_wdt.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/watchdog/w83627hf_wdt.c b/drivers/watchdog/w83627hf_wdt.c index 2957364485eb..7b50865ae824 100644 --- a/drivers/watchdog/w83627hf_wdt.c +++ b/drivers/watchdog/w83627hf_wdt.c @@ -485,7 +485,8 @@ static int wdt_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_IO, 0); if (!res) - return -ENXIO; + return dev_err_probe(dev, -ENXIO, + "failed to get I/O resource\n"); data->info.options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE; snprintf(data->info.identity, sizeof(data->info.identity), @@ -540,12 +541,12 @@ static int wdt_probe(struct platform_device *pdev) } if (ret) - return ret; + return dev_err_probe(dev, ret, "failed to set watchdog timeout\n"); } ret = devm_watchdog_register_device(&pdev->dev, wdd); if (ret) - return ret; + return dev_err_probe(dev, ret, "failed to register watchdog\n"); dev_info(dev, "initialized. timeout=%d sec (nowayout=%d)\n", wdd->timeout, nowayout); -- 2.55.0