Re: [PATCH 1/4] watchdog: qcom: Propagate errors from optional IRQ lookup
Bui Duc Phuc <[email protected]>
| Newsgroups | org.kernel.vger.linux-watchdog,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.ozlabs.lists.linux-aspeed |
|---|---|
| Message-ID | <CAABR9nEGsisuuQhLwxdcB9i2sEuH=AQb3yaPHPNecya8G_5ieg@mail.gmail.com> |
Hi Guenter,
Thank you for your feedback.
>
> I wpuld probably implement something like
>
> if (data->pretimeout) {
> irq = platform_get_irq_optional(pdev, 0);
> if (irq < 0 && irq != -ENXIO)
> return irq;
> ret = devm_request_irq(dev, irq, qcom_wdt_isr, 0,
> "wdt_bark", &wdt->wdd);
> if (ret)
> return ret;
>
> wdt->wdd.info = &qcom_wdt_pt_info;
> wdt->wdd.pretimeout = 1;
> } else {
> wdt->wdd.info = &qcom_wdt_info;
> }
>
> (which I think would be a combination of B and C) but ultimately it is
> POV and doesn't really matter.
>
I'll go with your suggested approach.
Best regards,
Phuc