Re: [PATCH v3] watchdog: orion_wdt: Propagate errors from optional IRQ lookup
Guenter Roeck <[email protected]>
| Newsgroups | org.kernel.vger.linux-watchdog,dev.linux.lists.sashiko-reviews |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 10, 2026 at 08:36:31AM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > > Pre-existing issues: > - [High] Probe deferral of optional IRQs causes a running watchdog to reset the system. > - [High] Race condition in driver removal and error paths allows IRQ handler to access unclocked registers. The first problem can't be addressed without somehow selectively postponing IRQ handler registration, or in other words re-implementing probe deferral handling in the driver. We are not going to do that. Fixing the second problem will require using devm_clk_get_enabled() and is out of scope for this patch. Guenter