Re: [PATCH v3 1/8] dt-bindings: reset: Add mt6589 toprgu reset IDs

On Sun, Aug 09, 2026 at 06:03:25PM +0200, Luca Leonardo Scorcia wrote:
> Currently mt6589 watchdog driver implements the watchdog feature, but

Driver is not really relevant here. If device does not have resets, why
would you add them?


> not the reset controller feature, which is actually supported by the
> hardware.

So binding already has reset-cells or not?

I already asked at v1 to clearly express why you are doing this. You
will get the same comments if you do not improve commits.

> 
> Add the bit definitions for the 12 mt6589 toprgu resets, which will be

We do not take bits, but identifiers of resets.

If these are bits, then not really a binding, so drop entire header.

> used in the following patch to enable the reset controller. Values
> determined from stock Android sources.

Nope, Android does not matter here. We do not add bindings for other,
unreviewed projects with poor quality and poor processes.

> 
> Signed-off-by: Luca Leonardo Scorcia <[email protected]>
> ---
>  .../reset/mediatek,mt6589-resets.h            | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 include/dt-bindings/reset/mediatek,mt6589-resets.h
> 
> diff --git a/include/dt-bindings/reset/mediatek,mt6589-resets.h b/include/dt-bindings/reset/mediatek,mt6589-resets.h
> new file mode 100644
> index 000000000000..ee08c39df513
> --- /dev/null
> +++ b/include/dt-bindings/reset/mediatek,mt6589-resets.h

Filename must match compatible.

> @@ -0,0 +1,24 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Author: Luca Leonardo Scorcia <[email protected]>
> + */
> +
> +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT6589
> +#define _DT_BINDINGS_RESET_CONTROLLER_MT6589

Best regards,
Krzysztof