Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `samsung,exynos5515-wdt` compatible string is defined as a standalone string without a fallback, but corresponding support is entirely missing from the watchdog driver.
--
--- Patch [1]: [PATCH v2 1/2] dt-bindings: watchdog: samsung-wdt: Add exynos5515-wdt compatible ---
commit 1111ae2e418dde480b9a0bc5f9cb740eb0c3a137
Author: Aiden Isik <[email protected]>
dt-bindings: watchdog: samsung-wdt: Add exynos5515-wdt compatible
Add a dt-binding compatible for the Exynos5515 watchdog timer.
> diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> index 41aee1655b0c2..a32c478315779 100644
> --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> @@ -22,6 +22,7 @@ properties:
> - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4
> - samsung,exynos5250-wdt # for Exynos5250
> - samsung,exynos5420-wdt # for Exynos5420
> + - samsung,exynos5515-wdt
[Severity: Medium]
Does this standalone compatible string need a corresponding entry in the
watchdog driver to function?
Because there is no fallback compatible string provided in this binding, it
looks like the driver lacks a matching entry to probe the device. Looking at
the device ID table in drivers/watchdog/s3c2410_wdt.c:
drivers/watchdog/s3c2410_wdt.c
static const struct of_device_id s3c2410_wdt_match[] = {
...
{ .compatible = "google,gs101-wdt",
.data = &drv_data_gs101_cl0 },
...
};
Without an addition to s3c2410_wdt_match or a suitable fallback string in
the device tree, will the Exynos5515 watchdog silently fail to probe and
leave the hardware unsupported at runtime?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260818-for-next-lucky7-watchdog-v2-0-6743f479a47f@member.fsf.org?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.