Re: [PATCH v2 2/2] watchdog: s3c2410_wdt: Add exynos5515-wdt compatible data
Aiden Isik <[email protected]>
| Newsgroups | org.kernel.vger.linux-watchdog,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <MvMjoAjL-_p1bx0Hkz3LV5jIs_HCsdxe7agP0T68PVra0YpfiQpAP7DEkimB7y5HUZ6hbCYM1W713QZKI2E8AEwxIwPXHsX297CSck7_r64=@protonmail.com> |
Hi Guenter, > On 8/18/26 10:56, Aiden Isik wrote: > > Hi Guenter, > > > >> Aiden, > >> > >> On 8/18/26 08:53, [email protected] wrote: > >>> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > >>> - [High] The `drv_data_exynos5515` variant includes `QUIRK_HAS_PMU_AUTO_DISABLE` but fails to define `.disable_reg`, resulting in PMU register corruption at offset 0x0. > >>> - [High] The `drv_data_exynos5515` variant uses an INT_EN register for masking but fails to set `.mask_reset_inv = true`, inverting the watchdog masking logic. > >>> -- > >>> > >> Please either address or explain why those are non-issues. > >> > > > > For the 'disable_reg' issue Sashiko flagged, downstream says this: > > > >> /* PMU registers are changed. > >> * MASK_RESET register was replaced by CLUSTERx_NONCPU_INT_TYPE register. > >> * DISABLE register was removed and its value was always fixed by 0. > >> */ > > > > Which is why I omitted disable_reg. It no longer exists. > > > > What is "downstream" ? I do not see this comment in the patch, not > in linux-next as of next-20260817. Samsung's Linux kernel fork for Exynos5515. I host a mirror of it at https://github.com/Aiden-Isik/linux-android-lucky7. > > Guenter > > Kind regards, - Aiden Isik