Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing `#reset-cells` required property constraint for the `mediatek,mt8167-wdt` reset provider capability.
- [Medium] Missing `#reset-cells` required property constraint for the `mediatek,mt8167-mmsys` reset provider capability.
--
--- Patch [4]: [PATCH v4 4/7] dt-bindings: watchdog: Add compatible for MediaTek mt8167 ---
commit cda604d8e57545578970aa161f863c629cec7278
Author: Luca Leonardo Scorcia <[email protected]>
dt-bindings: watchdog: Add compatible for MediaTek mt8167
This commit adds a dedicated compatible string for the MediaTek mt8167
watchdog. It also introduces two new header files defining reset IDs for
the toprgu (watchdog) and mmsys subsystems.
> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> index 953629cb9558b..f514be8a5851d 100644
> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> @@ -26,6 +26,7 @@ properties:
> - mediatek,mt6795-wdt
> - mediatek,mt7986-wdt
> - mediatek,mt7988-wdt
> + - mediatek,mt8167-wdt
[Severity: Medium]
Since this compatible string is being added as a reset provider (indicated by
the new mediatek,mt8167-wdt.h header), should #reset-cells be added as a
required property constraint for mediatek,mt8167-wdt?
Without this constraint, device tree nodes using the mediatek,mt8167-wdt
compatible string could silently pass validation even if they omit
#reset-cells. This would allow incomplete configurations to escape schema
verification, leading to downstream driver or probe failures when another node
attempts to reference it as a reset provider.
[ ... ]
> diff --git a/include/dt-bindings/reset/mediatek,mt8167-mmsys.h b/include/dt-bindings/reset/mediatek,mt8167-mmsys.h
> new file mode 100644
> index 0000000000000..b21f67b3b55c7
> --- /dev/null
> +++ b/include/dt-bindings/reset/mediatek,mt8167-mmsys.h
> @@ -0,0 +1,35 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
> +#ifndef _DT_BINDINGS_RESET_MEDIATEK_MT8167_MMSYS_H_
[Severity: Medium]
This new header introduces reset IDs for the mt8167-mmsys hardware, formally
making it a reset provider.
Does the Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
schema also need to be updated in this patch to require the #reset-cells
property for the mediatek,mt8167-mmsys hardware?
If the schema is not updated, a device tree author could attempt to use an
mt8167 mmsys node as a reset provider but forget to specify #reset-cells,
which would pass schema validation but fail to provide resets at runtime.
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.