Re: [PATCH] wifi: mt76: mt7925: cancel mlo_pm_work on stop

Felix,

Today I just verified the last sentence of that commit message is wrong. I previously wrote:

  mt7925_ops backs both the PCIe and USB drivers, so this covers both.

It does not. mt7925u_probe() overwrites the stop entry with mt792xu_stop, so mt7925_stop() never
runs on USB. I traced a teardown on an mt7925u adapter with the patch applied:
mt792xu_stop runs, mt7925_stop does not.

I have also now reproduced the original warning on mt7925u, on a tree with no cancel at all,
which I was not able to do in June:

  workqueue: cannot queue mt7925_mlo_pm_work [mt7925_common] on wq phy10

So the patch covers the PCIe path only. If dd84a549868f has not gone up yet, dropping that one
sentence would be enough. The USB path still needs the cancel. There is one in usb.c already,
but it sits in mt7925u_suspend(), and rmmod and unplug go through .disconnect =
mt792xu_disconnect().

Devin