Re: [PATCH] wifi: rtl818x: initialize eeprom_93cx6 struct to zero
Ping-Ke Shih <[email protected]>
| Newsgroups | org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
[email protected] wrote: > From: Stanislaw Gruszka <[email protected]> > > Commit 7738a7ab9d12 ("misc: eeprom: eeprom_93cx6: Add quirk for extra > read clock cycle") added extra 'quirk' field to struct eeprom_93cx6. > > Many existing users of eeprom_93cx6, including rtl818x drivers, allocate > the structure on the stack without initializing all fields. As a result, > the added quirk field has an undefined value and can randomly cause > reading wrong data from the EEPROM. > > Fix by initializing the structures with {}. > > Fixes: 7738a7ab9d12 ("misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle") > Cc: [email protected] # v6.13+ > Signed-off-by: Stanislaw Gruszka <[email protected]> > Reviewed-by: Ping-Ke Shih <[email protected]> 1 patch(es) applied to rtw-next branch of rtw.git, thanks. 799b5f45cb81 wifi: rtl818x: initialize eeprom_93cx6 struct to zero --- https://github.com/pkshih/rtw.git