Re: [PATCH 05/19] wifi: rtw88: fw: send rate adaptation and RSSI info in the vendor layout

[email protected]
Newsgroups org.kernel.vger.linux-wireless,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
From: Luka Gejak <[email protected]>

On 25/07/2026 02:46, Bitterblue Smith wrote:
> Not sure where you found the value 0x04. I see in
> hal/phydm/phydm_rssi_monitor.c that it's setting bit 1, same as rtw88.
> The other bytes you set here are equivalent to the macros in the else
> branch.

Agreed, there is nothing here the existing macros do not already do.

> This doesn't look like the vendor driver's behaviour. To me it
> looks like rtw88 is already handling the no_update bit correctly.
>
> I bet you don't need to modify rtw_fw_send_ra_info() at all.

You are right. Without the patch the negotiated rate and uplink are
unchanged, MCS7 either way, so the whole patch is dropped in v2.

Best regards,
Luka Gejak
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.