Re: [PATCH 17/19] wifi: rtw88: calibrate and tune the PHY for RTL8723BS

From: Luka Gejak <[email protected]>

On 25/07/2026 00:05, Bitterblue Smith wrote:
> These are three separate things, so they should be three patches.

The patch is dropped entirely in v2. None of the three survived
re-testing.

> This behaviour is already implemented for all the chips, although with
> even higher gain (0x1c) than what you're setting here (0x1e). See
> rtw_phy_dig_set_max_coverage(). Does it not work?

It works, and better than the override: five scans found 41 BSSes
without it against 34 with it.

> This chip only handles the 2.4 GHz band, so checking the current band
> should not be necessary.

True, though the function is gone now.

> With this you are always setting the same TX power, hardcoded in
> rtw8723bs_pg_txagc. What is the reason for that?
>
> Normally the TX power depends on values burned into the chip's efuse
> (so they vary from device to device), and values hardcoded into the
> driver are only used if there is nothing in the chip's efuse.

There is no good reason, and this one was the worst of the three. The
efuse path works: the by-rate table gives sensible values with the
regulatory limit applied, and the hardcoded table was overriding them
by up to 22 index units and bypassing that limit.

> In rtw88 the IQ calibration is normally done in the phy_calibration
> function (from rtw_chip_ops) which runs right before connecting to a
> network, not in the power on code. Wouldn't that be fine for this chip
> too?

It is fine. v2 uses the normal phy_calibration path.

Best regards,
Luka Gejak