[RFC PATCH 00/12] wifi: mac80211: install group keys to STA

Johannes Berg <[email protected]> Sat, 1 Aug 2026 09:58:16 +0200
Newsgroups org.kernel.vger.linux-wireless
Message-ID <[email protected]>
Hi,

First of all, I should state that this requires Benjamin's CIP work:
https://lore.kernel.org/linux-wireless/20260731154006.7bddd2d85ff1.I49c0be0a1b05d625cc307e9bdd13c32a6c18667f@changeid/
(It's therefore going to fail NIPA, but as RFC ...)

There are multiple motivations here, obviously the first is the
"headline feature" here:
 - Prepare for SMD Transition: During SMD Transition, new group keys
   become available after ST Execution, well before really switching
   to the new AP (in current AP MLD execution mode).
 - Clean up the TX/RX internal key lookups by unifying RX group key
   handling across all interface types (at least IBSS and mesh already
   required to link it into a station).
 - And something Jouni pointed out yesterday: group keys apparently
   aren't (always?) correctly removed when disconnecting, this will
   clearly clear that up as well, somewhat as a side effect.

The design involves cfg80211 so that existing userspace (wpa_s) can
work as-is, without giving the station address for group keys. This
is clearly necessary, and it might perhaps continue relying on that
rather than getting special code paths for different kernels, though
of course SMD Transition group key installs will need to be with the
MAC address.

The debugfs file here is required for hostap tests, they currently
decide whether or not a key is pairwise or not based on the station
link/mac address in debugfs, but that breaks with this since it'll
always be present (and I decided breaking the debugfs API was OK,
rather than preserving that), so the tests will need to read this
new flags file to check instead - I have the necessary adjustments,
of course.

The last two patches are just something that we wanted for various
reasons and that fell out fairly easily after doing all the other
refactoring in this work, it's not critical for any of the stated
goals, it's a bit of a side quest. It could also be improved, but
the most important thing there for us was patch 11 for NAN.

And since I'm mentioning SMD Transition so much: I pretty much have
much of the remaining bits and pieces for client side in mac80211,
and Ilan has the wpa_s (and minimal hostapd, for testing) code too,
but it needs significant further work and cleaning up, and possibly
significant redesign of TXQ infrastructure in mac80211 to allow us
to transfer packets to the new AP queues.

johannes