Re: [PATCH wireless-next v2 2/8] wifi: mac80211: change public RX API to use link stations

Jeff Johnson <[email protected]> Tue, 4 Aug 2026 06:39:04 -0700
Newsgroups org.kernel.vger.linux-wireless
Message-ID <[email protected]>
On 8/3/2026 5:30 AM, Benjamin Berg wrote:
> From: Benjamin Berg <[email protected]>
> 
> If a station is passed then the link ID also needs to be known. As such,
> it is a more natural API to simply pass the link station directly rather
> than pushing the link information into the RX status.
> 
> Furthermore, having the link ID in the RX status is not actually correct
> because the link IDs are VIF specific and there may be multiple VIFs. In
> the case of a station this relationship is clear, but then one may as
> well use the link station.
> 
> This patch only changes the API and emulates the old (incorrect)
> behaviour for now. The mac80211 RX code will be updated in later
> patches.
> 
> Signed-off-by: Benjamin Berg <[email protected]>
> 
> ---
> 
> v2:
>  * Remove now unused variable in rtw89
> 
> v1:
>  * Do not dereference NULL station
> ---
>  drivers/net/wireless/ath/ath11k/dp_rx.c       |  2 +-
>  drivers/net/wireless/ath/ath12k/dp_mon.c      |  2 --
>  drivers/net/wireless/ath/ath12k/dp_rx.c       | 20 +++++++++++++----
>  drivers/net/wireless/ath/ath12k/hw.h          | 20 +++++++++--------
>  drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c | 20 ++++++++---------
>  drivers/net/wireless/ath/ath12k/wifi7/dp_rx.h | 12 +++++-----
>  drivers/net/wireless/ath/ath12k/wifi7/hw.c    |  6 ++---
>  drivers/net/wireless/ath/ath12k/wmi.c         |  6 -----
>  drivers/net/wireless/intel/iwlwifi/mld/rx.c   |  7 +-----
>  drivers/net/wireless/intel/iwlwifi/mvm/rx.c   |  2 +-
>  drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c |  6 ++---
>  drivers/net/wireless/mediatek/mt76/mac80211.c | 22 +++++++++++--------
>  drivers/net/wireless/realtek/rtw89/core.c     |  7 ------
>  .../wireless/virtual/mac80211_hwsim_main.c    |  3 ---
>  include/net/mac80211.h                        | 16 ++++++++++----
>  net/mac80211/rx.c                             | 20 ++++++++++++-----
>  16 files changed, 91 insertions(+), 80 deletions(-)

btw please use get_maintainer.pl to get a list of all of the affected driver
maintainers and mailing lists and add them as recipients of the next version.

/jeff